frontend multi-chain multi-agent support #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truemiller
changed the title
truemiller
commented
Nov 11, 2024
Comment on lines
+26
to
+29
| [ContractType.StakingActivity]: new MulticallContract( | ||
| '0x7Fd1F4b764fA41d19fe3f63C85d12bf64d2bbf68', | ||
| STAKING_TOKEN_PROXY_ABI, | ||
| ), |
There was a problem hiding this comment.
@truemiller need to move this to activityCheckers config
mohandast52
reviewed
Nov 11, 2024
| @@ -7,7 +7,7 @@ | |||
| "@tanstack/react-query": "^5.29.0", | |||
| "adm-zip": "^0.5.12", | |||
| "antd": "^5.14.0", | |||
There was a problem hiding this comment.
maybe a good time to update ant?
Comment on lines
32
to
36
| abstract getStakingRewardsInfo: Promise<unknown>; | ||
| abstract getAvailableRewardsForEpoch: Promise<unknown>; | ||
| abstract getStakingContractInfo: Promise<unknown>; | ||
| abstract getStakingContractInfoByServiceIdStakingProgramId: Promise<unknown>; | ||
| abstract getStakingContractInfoByStakingProgramId: Promise<unknown>; |
There was a problem hiding this comment.
Do you think “Details” would be more accurate than “Info”?
Suggested change
| abstract getStakingRewardsInfo: Promise<unknown>; | |
| abstract getAvailableRewardsForEpoch: Promise<unknown>; | |
| abstract getStakingContractInfo: Promise<unknown>; | |
| abstract getStakingContractInfoByServiceIdStakingProgramId: Promise<unknown>; | |
| abstract getStakingContractInfoByStakingProgramId: Promise<unknown>; | |
| abstract getStakingRewardsInfo: Promise<unknown>; | |
| abstract getAvailableRewardsForEpoch: Promise<unknown>; | |
| abstract getStakingContractDetails: Promise<unknown>; | |
| abstract getStakingContractDetailsByServiceIdStakingProgramId: Promise<unknown>; | |
| abstract getStakingContractDetailsByStakingProgramId: Promise<unknown>; |
| ]; | ||
|
|
||
| const [ | ||
| getOperatorBalanceReponse, |
There was a problem hiding this comment.
I think it should be just
Suggested change
| getOperatorBalanceReponse, | |
| operatorBalanceResponse, |
| await OLAS_CONTRACTS[chainId][ContractType.Multicall3].all(contractCalls); | ||
|
|
||
| const [bondValue, depositValue, serviceState] = [ | ||
| parseFloat(ethers.utils.formatUnits(getOperatorBalanceReponse, 18)), |
There was a problem hiding this comment.
What if we create a separate utility for formatting these values? That way, if we decide to migrate to “viem,” we only need to update that utility function.
type supportedFormatValues = string | bigint;
const formatToEth = (x: supportedFormatValues) => ethers.utils.formatUnits(x, 18);| * - depositValue | ||
| * - serviceState | ||
| */ | ||
| static getServiceRegistryInfo = async ( |
There was a problem hiding this comment.
Suggested change
| static getServiceRegistryInfo = async ( | |
| static getServiceRegistryDetails = async ( |
| static getAvailableRewardsForEpoch = async ( | ||
| stakingProgramId: StakingProgramId, | ||
| chainId: ChainId = ChainId.Gnosis, | ||
| ): Promise<number | undefined> => { |
There was a problem hiding this comment.
Suggested change
| ): Promise<number | undefined> => { | |
| ): Promise<number> => { |
| stakingTokenProxy.minStakingDeposit(), | ||
| ]; | ||
|
|
||
| const multicallResponse = await multicallProvider.all(contractCalls); |
There was a problem hiding this comment.
same, we can add type here for all multicallResponse.
| // if (!services?.[0]) return; | ||
| // const serviceStatus = await ServicesService.getDeployment(services[0].hash); | ||
| // setServiceStatuses(serviceStatus.status); | ||
| // }, [services]); |
There was a problem hiding this comment.
any reason to keep them commented?
| /** | ||
| * @note This is a mapping of all native tokens on each chain. | ||
| */ | ||
| export const NATIVE_TOKEN_CONFIG = Object.fromEntries( |
There was a problem hiding this comment.
Do we really need this now 🤔.
| currency: TokenSymbol.XDAI, | ||
| middlewareChain: MiddlewareChainId.GNOSIS, | ||
| rpc: process.env.GNOSIS_RPC as HttpUrl, | ||
| }; |
There was a problem hiding this comment.
and below as well.
Suggested change
| }; | |
| } as const; |
refactor balance provider
…ent in BalanceProvider
… and improve balance loading logic
…or low balance specific to selected service
…agentnotrunningbutton refactor AgentNotRunningButton (useBalance consumer) + small changes to serviceTemplate, createService API, support multi-chain service templates and remove
…ce-section GasBalanceSection using service-specific balances, update Olas balance component, add safeWallets to useService
…stead of serviceStatus
…for wallet management
…roved wallet management
…elds Allow update metadata fields (description)
…dleware' into refactor/multi-chain-support-frontend
Co-authored-by: Mohan <[email protected]>
Release/v0.2.0 rc5
…to use selectedAgentConfig for balance calculations
…lance and MasterEoaSignerNativeBalance
release/v0.2.0-rc6
Fix/win env vars build
…middleware Allow multiple services on middleware (Major refactor)
fix zod schema for stakingRewardsDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply